Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL named group support in URLPattern #1358

Closed
wanderview opened this issue Mar 15, 2021 · 3 comments
Closed

RTL named group support in URLPattern #1358

wanderview opened this issue Mar 15, 2021 · 3 comments
Assignees
Labels
advice-requested The i18n WG has been asked to comment/advise. duplicate pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:urlpattern https://github.com/WICG/urlpattern t:resid_misc 6. Resource identifiers/Basics tracker i18n is following a discussion, but doesn't require resolution. whatwg https://whatwg.org/

Comments

@wanderview
Copy link
Member

wanderview commented Mar 15, 2021

This is a tracker issue. Only discuss things here if they are i18n WG internal meta-discussions about the issue. Contribute to the actual discussion at the following link:

§ whatwg/urlpattern#43

@r12a r12a added advice-requested The i18n WG has been asked to comment/advise. needs-attention The i18n WG should urgently review the status of this item. labels Mar 17, 2021
@r12a
Copy link
Contributor

r12a commented Mar 17, 2021

A tracker issue is not the place for technical discussions, so we'll need to find a place to put this. Maybe i18n-discuss??

@r12a r12a added the pending Issue not yet sent to WG, or raised by tracker tool & needing labels. label Mar 17, 2021
@r12a
Copy link
Contributor

r12a commented Feb 16, 2022

The following summarises the request to i18n WG, from wanderview on 21 Mar 2021.

No spec yet, this is being discussed in issues on the WICG proposal repo.
whatwg/urlpattern#43

In https://github.com/WICG/urlpattern we are incubating a new proposal for a URL pattern matching web API. Due to popularity among existing web developers we have chosen to base this on https://github.com/pillarjs/path-to-regexp. The path-to-regexp pattern syntax has support for named match groups like :foo. This follows existing URL matching conventions in other systems like ruby-on-rails.

In whatwg/urlpattern#43 it was raised that the :foo syntax is not RTL friendly because it presumes the beginning of the word is on the left. We have not been able to get any additional feedback from this person about example RTL URLs where this would be significant or what might be an acceptable solution.

Also, there is an additional potentially RTL problem. Since the group names are reflected in javascript properties we have chosen to make group names follow javascript identifier rules for allowed characters. This logic assumes that the first character is on the left of the string. From talking with javascript language experts it appears that the language is predominantly LTR and does not really have RTL support.

In whatwg/urlpattern#43 (comment) I am proposing that we maintain the status quo with :foo for now. I'm looking for additional i18n review to determine if the RTL concern is particularly concerning and if this outcome is reasonable. Thank you.

@xfq xfq added the s:urlpattern https://github.com/WICG/urlpattern label Jun 9, 2022
@aphillips aphillips removed pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:urlpattern https://github.com/WICG/urlpattern labels Jun 9, 2022
@aphillips aphillips self-assigned this Jun 9, 2022
@xfq xfq added the s:urlpattern https://github.com/WICG/urlpattern label Jun 9, 2022
@r12a r12a added the t:resid_misc 6. Resource identifiers/Basics label Jul 15, 2022
@xfq xfq added the tracker i18n is following a discussion, but doesn't require resolution. label Sep 12, 2023
@aphillips aphillips added duplicate and removed needs-attention The i18n WG should urgently review the status of this item. labels Sep 12, 2023
@aphillips
Copy link
Contributor

duplicates 1368

@w3cbot w3cbot added moved? pending Issue not yet sent to WG, or raised by tracker tool & needing labels. labels Jan 28, 2024
@plehegar plehegar removed the moved? label Jan 28, 2024
@w3cbot w3cbot added the whatwg https://whatwg.org/ label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advice-requested The i18n WG has been asked to comment/advise. duplicate pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:urlpattern https://github.com/WICG/urlpattern t:resid_misc 6. Resource identifiers/Basics tracker i18n is following a discussion, but doesn't require resolution. whatwg https://whatwg.org/
Projects
None yet
Development

No branches or pull requests

6 participants