Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 21 contains an undefined term #1564

Open
filip26 opened this issue Sep 17, 2024 · 5 comments
Open

Example 21 contains an undefined term #1564

filip26 opened this issue Sep 17, 2024 · 5 comments
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification. ready for PR This issue is ready for a Pull Request to be created to resolve it

Comments

@filip26
Copy link
Contributor

filip26 commented Sep 17, 2024

see Example 21

assertion is an undefined term. Possible solutions:

  • remove assertion and replace it description for example, which is defined
  • remove credential scoped @context
  • add examples context to the credential scoped @context, duplicate the main @context
@filip26
Copy link
Contributor Author

filip26 commented Sep 17, 2024

the same for Example 20

@msporny msporny added editorial Purely editorial changes to the specification. CR1 This item was processed during CR1 labels Sep 18, 2024
@msporny
Copy link
Member

msporny commented Sep 18, 2024

The example uses the https://www.w3.org/ns/credentials/examples/v2 context, which includes an @vocab statement. That makes assertion defined. Yes, it's a bit sloppy, but that's what the examples context is there for -- to make the content valid so we can demonstrate an example.

I suggest we keep the example as-is, as it is what we intended. Would you be ok with that, @filip26?

@filip26
Copy link
Contributor Author

filip26 commented Sep 18, 2024

@msporny It's a presentation, the main @context is erased in v20 for verifiableCredential.

Easiest fix is to replace assertion with description for 21, and replace favoriteCheese in example 20 with something else, .e.g. @id name, as those props are not important for the examples. I can open PR if this 'fix' is OK.

I've found another issues like those, e.g. non-dereferenceable contexts in examples. Do you prefer to have it reported, or is there some plan to fix all the examples in once?

@filip26
Copy link
Contributor Author

filip26 commented Sep 18, 2024

or move examples context to credential scoped context, it could be a nice example that there can be more contexts embedded .

@davidlehn
Copy link
Contributor

I'd add the examples context to the inner credential. A move wouldn't work since the presentation uses ExamplePresentation which needs to be handled as well.

@msporny msporny added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification. ready for PR This issue is ready for a Pull Request to be created to resolve it
Projects
None yet
Development

No branches or pull requests

3 participants