Skip to content

Commit 6a7b460

Browse files
committed
feedback
1 parent 0f9bc8c commit 6a7b460

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

proposals/manifest_trial_tokens.md

+13-8
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,9 @@ Upon manifest parsing, browser should parse `trial_tokens` like so:
117117
3.5. (optionally) attempt to parse the token and validate it. If validation
118118
fails, skip the token and (optionally) log a benign warning.
119119
Note: browsers may disregard token expiration errors, if they are not
120-
sure about the corrctness of system timestamp at the time of token
121-
validation
120+
sure about the correctness of system timestamp at the time of token
121+
validation. Browsers may validate tokens asynchroneously, if their
122+
implementation requires this.
122123
3.6. append token to the collection of accepted tokens
123124
4. if at least one token is accepted in step 3, save the token collection in
124125
parsed manifest under `trial_tokens` key
@@ -151,12 +152,16 @@ Trial tokens system already incorporate some degree of abuse mitigations:
151152

152153
### Additional Security Considerations
153154

154-
This new manifest key contains values which will be inserted into headers of
155-
local HTTP-like responses. Browsers must ensure that the provided tokens can
156-
not escape header serealization. Browsers also must ensure that tokens do not
157-
cause headers to exceed implementation-specific limits so that response is
158-
processed in different way (e.g., adding a large number of tokens must not
159-
cuase removal of security headers like CSP).
155+
This new manifest key contains values which will be consumed by the browser's
156+
experimental API trial system. Browsers may need to take special care to ensure
157+
that provided tokens do not violate the expectations of these systems.
158+
159+
For example, Chromium's trial system exposes tokens in headers of local
160+
HTTP-like responses. As a result, it must ensure that the provided tokens can
161+
not escape header serealization. it also must ensure that tokens do not cause
162+
headers to exceed implementation-specific limits so that response is processed
163+
in different way (e.g., adding a large number of tokens must not cuase removal
164+
of security headers like CSP).
160165

161166
## Alternatives
162167

0 commit comments

Comments
 (0)