Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support display local image #103

Open
zhangwilling opened this issue Aug 23, 2018 · 2 comments
Open

support display local image #103

zhangwilling opened this issue Aug 23, 2018 · 2 comments

Comments

@zhangwilling
Copy link

zhangwilling commented Aug 23, 2018

This is an enhancement.

some images are not remote, such as '/private/var/mobile/Containers/Data/Application/33750DB7-00A8-4537-837D-7747800EB4B5/tmp/react-native-image-crop-picker/459488B7-E263-4325-95DC-AD539779FBAC.jpg'

we can judge if image source is a remote at here.

protected getProps() {

If the image is local, we don't need to invoke download function and notify.

private download(cache: CacheEntry) {

@zhangwilling
Copy link
Author

i create a pr at #104 to enhance the lib.

@wumke
Copy link

wumke commented Jul 12, 2019

Imho it is useless to handle local files in a component that you pulled in to handle cache... instead that should be a simple new component that judges to use default Image or CachedImage when remote url!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants