-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./wpt run firefox path/to/someTest
doesn't run tests when Firefox is installed via Snap
#44321
Comments
What happens if you pass This runs to completion for me:
|
|
@gsnedders is using macOS, btw. |
@mbrodesser-Igalia which version of Firefox are you running? Is that one that got installed via Snap? The logs show that |
It still fails with
|
@whimboo to generate the logs for the previous comments, the default channel was used, which is supposed to be Nightly. Version: 123.0a1 (2024-01-17) (64-bit). That, AFAIR, was not installed via Snap. However, with the release channel, the test still fails:
That one uses Firefox 122.0 (64-bit).
|
No-headless with release fails too:
|
Ok, so the last log is actually helpful. As I can see you indeed use the snap version of geckodriver and Firefox. The failure here seems to be with loading the |
Oh wait... actually I just saw: Can you please try with a Firefox and geckodriver build as downloaded from mozilla.org? If my theory is right we need Snap support in wptrunner. |
@whimboo be reminded that e.g. #44321 (comment) was generated with the default channel (Nightly). However, the corresponding logs show
which isn't Nightly. That might be a separate issue from the potential one with Snap. |
@whimboo: log generated with Firefox downloaded from mozilla.org:
That is, it indeed worked with the non-Snap version. |
Right. We diverged a bit from the original issue. So most likely the problem is somewhere in this Firefox class and the binary under Line 197 in 34dd07e
If you would have the time and could test I would appreciate. I don't have a Linux system setup using the Snap Firefox package, and @jgraham is away at the moment. |
@whimboo: are you using Ubuntu with Snap support? If so, one can install Firefox from mozilla.org and the Snap package, switching via the |
No, I'm on MacOS and as such cannot easily test this scenario. |
./wpt run firefox path/to/someTest
doesn't run tests./wpt run firefox path/to/someTest
doesn't run tests when Firefox is installed via Snap
Sorry, there are more urgent issues I currently need to work on. Consider installing a VM with Ubuntu. |
No worries it might have to wait then until @jgraham is back. I'm not really working on wptrunner but trying to help with investigations. Thanks for filing! |
Works with "chrome" instead of "firefox".
In both cases:
./wpt run firefox trusted-types/block-string-assignment-to-Element-setAttribute.html Running 1 tests in web-platform-tests
is logged.
Happened on Ubuntu 22.04.
The text was updated successfully, but these errors were encountered: