Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to deal with Co-authored-by? #17

Open
SamYuan1990 opened this issue Nov 26, 2024 · 1 comment
Open

how to deal with Co-authored-by? #17

SamYuan1990 opened this issue Nov 26, 2024 · 1 comment

Comments

@SamYuan1990
Copy link

step 1 I submit a PR.
step 2 I accept some change request.

as the change request/suggestion is accepted from webUI.
so the commit msg like

Co-authored-by: Maryam Tahhan <[email protected]>
  Signed-off-by: Sam Yuan <yy[19](https://github.com/sustainable-computing-io/kepler/actions/runs/12026779534/job/33526430942?pr=1856#step:3:20)[email protected]>
  🚩 Update CONTRIBUTING.md

is there any way to avoid this kind of issue or I should add commit msg before accept commit from webUI?

@doomspork
Copy link

I'm not the maintainer but having run into this ourselves we made the decision to not use the Github UI to make changes since the resulting commits are not compatible with conventional commits and as a result, this action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants