Fix #961: Removed old visualization code from evaluate.py #965
+24
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrykironde
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks @Bhavya1604 for getting to work on this PR. I expected some changes in the tests too.
|
@henrykironde Thanks for the feedback! I’m working on updating the tests and will push the changes soon. |
|
I have made the following changes:
All tests have passed on my local system. Let me know if any further changes are needed! |
tests/test_evaluate.py
Outdated
| @@ -113,9 +106,8 @@ def test_point_recall_image(root_dir, tmpdir): | |||
| img_path = get_data("OSBS_029.png") | |||
| if root_dir == "tmpdir": | |||
There was a problem hiding this comment.
Do we still root_dir here?
There was a problem hiding this comment.
No, it's not required. I missed it thanks for catching that! I'll update it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the old visualization code from evaluate.py, as requested in issue #961
The changes include:
Removing root_dir from evaluate_image_boxes and evaluate_boxes.
Eliminating unnecessary visualize.plot_predictions and cv2.imwrite calls.
Ensuring all related functions remain functional without visualization dependencies.
All tests are passing, except for an unrelated JSON test.
Looking forward to your feedback!
Thanks!