Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back option to configure target SNMP port #23

Closed
amotl opened this issue Mar 12, 2022 · 7 comments · Fixed by #46
Closed

Bring back option to configure target SNMP port #23

amotl opened this issue Mar 12, 2022 · 7 comments · Fixed by #46

Comments

@amotl
Copy link
Contributor

amotl commented Mar 12, 2022

Hi,

A custom port can be specified by using -p. The default value is 161.

I just discovered that the refactoring coming from #4/#19 dropped that feature to specify the target SNMP port number (#2), so we will have to bring it back when there is demand.

Also, after integrating #21, the Icinga configuration snippets will provide access to almost all parameters this program has to offer. However, the -p option is still missing there. Also depending on community demand, this can be added every time.

With kind regards,
Andreas.

@amotl amotl changed the title Provide option to configure port number through Icinga Bring back option to configure target SNMP port Mar 12, 2022
@wernerfred
Copy link
Owner

wernerfred commented Mar 12, 2022

Good catch, I would like to have this functionality back in the script (still with default so that one does not have to use it). Adding it to the example files is a good idea, too 👍🏻

@amotl
Copy link
Contributor Author

amotl commented Mar 12, 2022

I will try to take care about it within one of the next iterations.

@wernerfred
Copy link
Owner

Current README also lists setting the port as an option. Should remove the part from the README in the meantime to not confuse new users?

@wernerfred
Copy link
Owner

wernerfred commented Jun 8, 2022

As #31 now got merged i would like to publish a new release. But as the option to configure a target port is still a regression it would be a major version. So i am drafting a feature version bump as a pre release and release "normal" one as soon as this regression is solved.

EDIT: published pre-release v0.4.0-beta.1

@amotl
Copy link
Contributor Author

amotl commented Aug 3, 2022

Dear Frederic,

I will re-add this option in the course of the next iterations. That's why I wanted to add #39 ff. beforehand.

In the meanwhile, as I found out just yesterday, everyone can use a composite host syntax like appliance.example.net:1161, just adding the port number to the host name. Easy SNMP accepts that as well.

With kind regards,
Andreas.

@wernerfred
Copy link
Owner

Braindump (for future me or others): The corresponding option for the easysnmp Session should be remote_port.

@bigitag
Copy link
Contributor

bigitag commented Oct 13, 2022

I added the missing port definition to easysnmp.Session in #46

@wernerfred wernerfred linked a pull request Oct 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants