From 606912bd9839af0c4f3ca84612d1cdca68b7217a Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Tue, 29 May 2018 13:12:10 +0200 Subject: [PATCH 1/2] Meta: Review Draft infrastructure See https://github.com/whatwg/whatwg.org/issues/197 and https://github.com/whatwg/meta/issues/92 for details. This also updates the web-platform-tests URL. --- .gitignore | 1 + Makefile | 10 +++++++--- README.md | 4 ++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 350e7f9..2cfdbb8 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,4 @@ deploy_key console.spec.whatwg.org/ .DS_Store .idea +review.sh diff --git a/Makefile b/Makefile index 46f2ff1..5141509 100644 --- a/Makefile +++ b/Makefile @@ -1,14 +1,18 @@ SHELL=/bin/bash -o pipefail -local: index.bs - bikeshed spec index.bs index.html --md-Text-Macro="SNAPSHOT-LINK LOCAL COPY" - remote: index.bs curl https://api.csswg.org/bikeshed/ -f -F file=@index.bs > index.html -F md-Text-Macro="SNAPSHOT-LINK LOCAL COPY" +local: index.bs + bikeshed spec index.bs index.html --md-Text-Macro="SNAPSHOT-LINK LOCAL COPY" + # Don't confuse make given we have files called "local" or "remote" in our root dir .PHONY: local remote deploy: index.bs curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh EXTRA_FILES="images/*.*" bash ./deploy.sh + +review: index.bs + curl --remote-name --fail https://resources.whatwg.org/build/review.sh + EXTRA_FILES="images/*.*" bash ./review.sh diff --git a/README.md b/README.md index 5bf9d2d..a8aeb58 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ This specification is still in its very early stages. It is very much a work in ## Tests -Tests can be found in the `console/` directory of [web-platform-tests](https://github.com/w3c/web-platform-tests). +Tests can be found in the `console/` directory of [web-platform-tests/wpt](https://github.com/web-platform-tests/wpt). ## Contribution guidelines @@ -22,4 +22,4 @@ If you can commit to this repository, see the [WHATWG Maintainer Guidelines](htt ## Code of conduct -We are committed to providing a friendly, safe and welcoming environment for all. Please read and respect the [WHATWG Code of Conduct](https://whatwg.org/code-of-conduct). +We are committed to providing a friendly, safe, and welcoming environment for all. Please read and respect the [WHATWG Code of Conduct](https://whatwg.org/code-of-conduct). From 920e4cecef5d4860d529ba35b0d52abef6233e7b Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Tue, 29 May 2018 15:28:34 +0200 Subject: [PATCH 2/2] review feedback --- .gitignore | 20 ++++++++++---------- Makefile | 5 +++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/.gitignore b/.gitignore index 2cfdbb8..5e0d1bf 100644 --- a/.gitignore +++ b/.gitignore @@ -1,11 +1,11 @@ -node_modules/ -npm-debug.log -index.html +/node_modules/ +/npm-debug.log +/index.html -console_spec_id_rsa -deploy.sh -deploy_key -console.spec.whatwg.org/ -.DS_Store -.idea -review.sh +/console_spec_id_rsa +/deploy.sh +/deploy_key +/console.spec.whatwg.org/ +/.DS_Store +/.idea +/review.sh diff --git a/Makefile b/Makefile index 5141509..969aced 100644 --- a/Makefile +++ b/Makefile @@ -11,8 +11,9 @@ local: index.bs deploy: index.bs curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh - EXTRA_FILES="images/*.*" bash ./deploy.sh + EXTRA_FILES="images/*.*" \ + bash ./deploy.sh review: index.bs curl --remote-name --fail https://resources.whatwg.org/build/review.sh - EXTRA_FILES="images/*.*" bash ./review.sh + bash ./review.sh