metric: add change request response time (X-lab2017#1156)

Signed-off-by: frank-zsy <[email protected]>

Signed-off-by: frank-zsy <[email protected]>

Author: frank-zsy

.mocharc.json

@@ -3,5 +3,5 @@
     "ts"
   ],
   "require": "ts-node/register",
-  "timeout": "20000"
+  "timeout": "30000"
 }

src/metrics/chaoss.ts

@@ -341,9 +341,9 @@ export const chaossIssueResolutionDuration = (config: QueryConfig<ResolutionDura
 export const chaossChangeRequestResolutionDuration = (config: QueryConfig<ResolutionDurationOptions>) =>
   chaossResolutionDuration(config, 'change request');
 
-export const chaossIssueResponseTime = async (config: QueryConfig<TimeDurationOption>) => {
+const chaossResponseTime = async (config: QueryConfig<TimeDurationOption>, type: 'issue' | 'change request') => {
   config = getMergedConfig(config);
-  const whereClauses: string[] = ["type IN ('IssueCommentEvent', 'IssuesEvent') AND actor_login NOT LIKE '%[bot]'  "];
+  const whereClauses: string[] = type === 'issue' ? ["type IN ('IssueCommentEvent', 'IssuesEvent') AND actor_login NOT LIKE '%[bot]'"] : ["type IN ('IssueCommentEvent', 'PullRequestEvent', 'PullRequestReviewCommentEvent', 'PullRequestReviewEvent') AND actor_login NOT LIKE '%[bot]'"];
   const repoWhereClause = await getRepoWhereClauseForClickhouse(config);
   if (repoWhereClause) whereClauses.push(repoWhereClause);
   const endDate = new Date(`${config.endYear}-${config.endMonth}-1`);
@@ -354,7 +354,7 @@ export const chaossIssueResponseTime = async (config: QueryConfig<TimeDurationOp
   const sortBy = filterEnumType(config.options?.sortBy, timeDurationConstants.sortByArray, 'avg');
 
   const sql = `
-SELECT 
+SELECT
   id,
   argMax(name, time),
   ${getGroupArrayInsertAtClauseForClickhouse(config, { key: `avg`, defaultValue: 'NaN' })},
@@ -409,6 +409,11 @@ ${getOutterOrderAndLimit(config, sortBy, sortBy === 'levels' ? 1 : undefined)}`;
   });
 };
 
+export const chaossIssueResponseTime = (config: QueryConfig<TimeDurationOption>) => chaossResponseTime(config, 'issue');
+
+export const chaossChangeRequestResponseTime = (config: QueryConfig<TimeDurationOption>) =>
+  chaossResponseTime(config, 'change request');
+
 // Evolution - Code Development Efficiency
 export const chaossChangeRequestsAccepted = async (config: QueryConfig) => {
   config = getMergedConfig(config);

src/metrics/index.ts

@@ -2,7 +2,7 @@ import { getRepoOpenrank, getRepoActivity, getUserOpenrank, getUserActivity, get
 import {
   chaossCodeChangeCommits, chaossBusFactor, chaossIssuesNew, chaossIssuesClosed, chaossChangeRequestsAccepted,
   chaossChangeRequestsDeclined, chaossIssueResolutionDuration, chaossCodeChangeLines, chaossTechnicalFork,
-  chaossChangeRequests, chaossChangeRequestReviews, chaossNewContributors, chaossChangeRequestsDuration, chaossIssueResponseTime, chaossChangeRequestsAcceptanceRatio, chaossIssuesActive, chaossActiveDatesAndTimes, chaossChangeRequestResolutionDuration,
+  chaossChangeRequests, chaossChangeRequestReviews, chaossNewContributors, chaossChangeRequestsDuration, chaossIssueResponseTime, chaossChangeRequestsAcceptanceRatio, chaossIssuesActive, chaossActiveDatesAndTimes, chaossChangeRequestResolutionDuration, chaossChangeRequestResponseTime,
 } from './chaoss';
 import { repoStars, repoIssueComments, repoParticipants, userEquivalentTimeZone } from './metrics';
 import { getRelatedUsers } from './related_users';
@@ -26,6 +26,7 @@ module.exports = {
   chaossIssueResolutionDuration: chaossIssueResolutionDuration,
   chaossChangeRequestResolutionDuration: chaossChangeRequestResolutionDuration,
   chaossIssueResponseTime: chaossIssueResponseTime,
+  chaossChangeRequestResponseTime: chaossChangeRequestResponseTime,
   chaossCodeChangeLines: chaossCodeChangeLines,
   chaossTechnicalFork: chaossTechnicalFork,
   chaossChangeRequests: chaossChangeRequests,

src/open_digger.js

@@ -43,6 +43,7 @@ const openDigger = {
       newContributors: func.chaossNewContributors,
       changeRequestsDuration: func.chaossChangeRequestsDuration,
       issueResponseTime: func.chaossIssueResponseTime,
+      changeRequestResponseTime: func.chaossChangeRequestResponseTime,
       technicalFork: func.chaossTechnicalFork,
       changeRequestsAcceptanceRatio: func.chaossChangeRequestsAcceptanceRatio,
       repoActiveDatesAndTimes: func.chaossRepoActiveDatesAndTimes,

test/metrics.test.ts

@@ -115,6 +115,18 @@ describe('Index and metric test', () => {
       const p = getParams('levels');
       await commonAssert(p[0], p[1], { index: 1, ...p[2] });
     });
+    it('change request response time', async () => {
+      const getParams = (key: string): [() => any, string, any] =>
+        [openDigger.chaossChangeRequestResponseTime, key, { noTotal: true, queryOptions: { options: { sortBy: key } } }];
+      await commonAssert(...getParams('avg'));
+      await commonAssert(...getParams('quantile_0'));
+      await commonAssert(...getParams('quantile_1'));
+      await commonAssert(...getParams('quantile_2'));
+      await commonAssert(...getParams('quantile_3'));
+      await commonAssert(...getParams('quantile_4'));
+      const p = getParams('levels');
+      await commonAssert(p[0], p[1], { index: 1, ...p[2] });
+    });
     it('code change lines', async () => {
       await commonAssert(openDigger.chaossCodeChangeLines, 'lines');
     });