Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create filters for bank statement descriptors #2841

Open
webdados opened this issue Jan 18, 2024 · 4 comments · May be fixed by #2842
Open

Create filters for bank statement descriptors #2841

webdados opened this issue Jan 18, 2024 · 4 comments · May be fixed by #2842

Comments

@webdados
Copy link

Scenario: Multi-lingual shop (in this case WPML, but it could be anything else) with a different domain name on each language.

For Spanish the bank statement should be tortillas.es and for Portuguese it should be pasteisdenata.pt

Today, it's possible to use the wc_stripe_generate_payment_request filter, but this would not make sure that the descriptors would go through the WC_Stripe_Helper::get_dynamic_statement_descriptor and/or WC_Stripe_Helper::clean_statement_descriptor methods on WC_Stripe_Payment_Gateway::generate_payment_request.

I suggest creating two filters on $statement_descriptor and $short_statement_descriptor at the beginning of the WC_Stripe_Payment_Gateway::generate_payment_request method.
webdados added a commit to webdados/woocommerce-gateway-stripe that referenced this issue Jan 18, 2024
@webdados
Add filters to statement descriptors
3aaa960 
Add filters to statement descriptors. Closes woocommerce#2841
@webdados webdados linked a pull request Jan 18, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Hi,
This issue has gone 150 days (5 months) without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest version, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@webdados
Copy link
Author

webdados commented Sep 3, 2024 •
edited
Loading

This is still needed but the PR has not being dealt with.

Anyway, on the new Stripe checkout experience I think the bank descriptor can no longer be set on the plugin and comes from the Stripe website.

@github-actions GitHub Actions
Copy link

Hi,
This issue has gone 150 days (5 months) without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest version, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@webdados
Copy link
Author

This is still needed but the PR has not being dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add filters to statement descriptors webdados/woocommerce-gateway-stripe
1 participant
@webdados