Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated PHP Error in WooCommerce Square Plugin #270

Open
qasumitbagthariya opened this issue Jan 16, 2025 · 1 comment · May be fixed by #304
Open

Deprecated PHP Error in WooCommerce Square Plugin #270

qasumitbagthariya opened this issue Jan 16, 2025 · 1 comment · May be fixed by #304
Assignees
@mukeshpanchal27
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically.

Comments

@qasumitbagthariya
Copy link
Contributor

Description:
While reviewing the Query Monitor, I noticed the following deprecated errors in the WooCommerce Square plugin:

Error: Creation of dynamic property WooCommerce\Square\Gateway\Gift_Card::$is_default_placeholder is deprecated.
Error: Creation of dynamic property WooCommerce\Square\Gateway\Gift_Card::$placeholder_id is deprecated.

Location:
wp-content/plugins/woocommerce-square/includes/Framework/PaymentGateway/Payment_Gateway.php:428

Steps to Reproduce:

  1. Enable the WooCommerce Square plugin.
  2. Monitor the Query Monitor for PHP errors.

Expected Behavior:
No deprecated errors should appear in the logs.

Actual Behavior:
The plugin triggers deprecated errors due to dynamic property creation.

Environment:

WordPress version: 6.7.1
PHP version: 8.2.23
WooCommerce Square version: 4.8.4
@qasumitbagthariya qasumitbagthariya mentioned this issue Jan 16, 2025
Merged
4 tasks
@jeffpaul jeffpaul added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Jan 21, 2025
@dkotter
Copy link
Contributor

dkotter commented Mar 6, 2025

@vikrampm1 Saw this deprecation notice today while testing the plugin prior to release. I think we should prioritize this as it should be a quick fix and will ensure we're not filling someone's debug logs

@vikrampm1 vikrampm1 added priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. and removed type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Mar 6, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Mar 12, 2025
@mukeshpanchal27 mukeshpanchal27 linked a pull request Mar 12, 2025 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated PHP error in WooCommerce Square plugin woocommerce/woocommerce-square
5 participants
@dkotter @jeffpaul @mukeshpanchal27 @qasumitbagthariya @vikrampm1