Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'@puppeteer/browsers' is classified as cjs? #10

Open
OrKoN opened this issue Sep 1, 2024 · 1 comment
Open

'@puppeteer/browsers' is classified as cjs? #10

OrKoN opened this issue Sep 1, 2024 · 1 comment

Comments

@OrKoN
Copy link

OrKoN commented Sep 1, 2024

I have noticed that @puppeteer/browsers seems to be classified as cjs although the exports map contains both require and import. It looks like dual esm/cjs packages might not be always detected correctly?

Also, I verified that for @puppeteer/browsers the ESM version is correctly picked up by Node's module loader.

@wooorm
Copy link
Owner

wooorm commented Sep 1, 2024

Impossible to track every engine, and what it will end up with, and whether that actually works at runtime.
But, "type": "commonjs", is what I see, and that's probably what the code uses to decide. Instead of looking further.
PR welcome, if you want to look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants