Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Zendesk tickets from Automatticians #21453

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Enable Zendesk tickets from Automatticians #21453

wants to merge 10 commits into from
+10 −20

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Nov 12, 2024 •
edited
Loading

Fixes #21449

Automatticians who have a Zendesk staff member role (admin, agent, etc.) identity have long been unable to test creating Zendesk tickets in the apps.

According to Zendesk, a workaround for this is to programmatically append "+testing" when a ticket is submitted from an @automattic.com or @a8c.com email address. This PR does just that.

To test:

  • Sign into an account with an Automattic email, or modify this line to use a hard-coded Automattic email
  • Verify that the feedback form now works
  • Verify that you can now submit support tickets

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 12, 2024 •
edited
Loading

2 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 12, 2024 •
edited
Loading

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21453-7d77222
Commit7d77222
Direct Downloadwordpress-prototype-build-pr21453-7d77222.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 12, 2024 •
edited
Loading

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21453-7d77222
Commit7d77222
Direct Downloadjetpack-prototype-build-pr21453-7d77222.apk
 Note: Google Login is not supported on these builds.

crazytonyli
crazytonyli reviewed Nov 12, 2024
View reviewed changes
WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java Outdated
// those with a staff member role (admin, agent, etc.), so insert "-testing"
// into the email to make it work
if ((email.contains("@automattic.com") || email.contains("@a8c.com")) && !email.contains("-testing@")) {
return email.replace("@", "-testing@");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are suppose to add an +testing, not -? /cc @jkmassel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazytonyli Thanks for catching that! I've made the correction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazytonyli Are we okay to merge this or are we waiting for @jkmassel to approve it?

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (535baed) to head (7d77222).
Report is 25 commits behind head on trunk.

Files with missing lines Patch % Lines
.../java/org/wordpress/android/ui/prefs/AppPrefs.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #21453   +/-   ##
=======================================
  Coverage   39.50%   39.50%           
=======================================
  Files        2119     2119           
  Lines       99437    99437           
  Branches    15282    15282           
=======================================
  Hits        39281    39281           
  Misses      56674    56674           
  Partials     3482     3482

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury marked this pull request as ready for review November 12, 2024 20:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

@jkmassel jkmassel Awaiting requested review from jkmassel

Assignees
No one assigned
Labels
Support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Append "+testing" to feedback form email for Automatticians
4 participants
@nbradbury @dangermattic @wpmobilebot @crazytonyli