Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository to be less strict about the definition and always return a url. #15

Open
martinheidegger opened this issue Oct 24, 2015 · 0 comments
Open

Fix repository to be less strict about the definition and always return a url. #15

martinheidegger opened this issue Oct 24, 2015 · 0 comments
Labels
bug

Comments

@martinheidegger
Copy link
Contributor

Right now the workshopper-adventure code looks for the git field in package.json which has a few ugly side-effects:

  1. This logic expects this to be an html link (workshopper/javascripting@232852a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L6)
  2. This logic breaks with an object. martinheidegger/scope-chains-closures@2f9087e
  3. After the installation when using npm it turns from https://github.com/sethvincent/javascripting.git to git+https://github.com/sethvincent/javascripting.git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinheidegger