clippy: Fix a variety of clippy warnings in fonts, layout_2020 and the DOM code (servo#33894)

* fixed some clippy warnings

Signed-off-by: L Ashwin B <[email protected]>

* Delete extra file

Signed-off-by: chickenleaf <[email protected]>

* preserved newline in compositionevent.rs

Co-authored-by: Martin Robinson <[email protected]>
Signed-off-by: chickenleaf <[email protected]>

* removed the newline in PrototypeList

Signed-off-by: L Ashwin B <[email protected]>

* removed the trailing whitespace

Signed-off-by: L Ashwin B <[email protected]>

---------

Signed-off-by: L Ashwin B <[email protected]>
Signed-off-by: chickenleaf <[email protected]>
Co-authored-by: Martin Robinson <[email protected]>

Author: chickenleaf

components/fonts/platform/windows/font.rs

@@ -6,7 +6,6 @@
 // information for an approach that we'll likely need to take when the
 // renderer moves to a sandboxed process.
 
-use std::cmp::{max, min};
 use std::fmt;
 use std::io::Cursor;
 use std::ops::Deref;

components/layout_2020/style_ext.rs

@@ -241,6 +241,7 @@ pub(crate) trait ComputedValuesExt {
         box_size: LogicalVec2<Size<Au>>,
         pbm: &PaddingBorderMargin,
     ) -> LogicalVec2<Size<Au>>;
+    #[allow(clippy::type_complexity)]
     fn content_box_sizes_and_padding_border_margin(
         &self,
         containing_block: &IndefiniteContainingBlock,

components/script/dom/bindings/codegen/CodegenRust.py

@@ -7935,6 +7935,7 @@ def PrototypeList(config):
             CGGeneric(AUTOGENERATED_WARNING_COMMENT),
             CGGeneric(f"pub const PROTO_OR_IFACE_LENGTH: usize = {len(protos) + len(constructors)};\n"),
             CGGeneric(f"pub const MAX_PROTO_CHAIN_LENGTH: usize = {config.maxProtoChainLength};\n\n"),
+            CGGeneric("#[allow(clippy::enum_variant_names)]"),
             CGNonNamespacedEnum('ID', protos, 0, deriving="PartialEq, Copy, Clone", repr="u16"),
             CGNonNamespacedEnum('Constructor', constructors, len(protos),
                                 deriving="PartialEq, Copy, Clone", repr="u16"),

components/script/dom/bindings/refcounted.rs

@@ -253,6 +253,7 @@ impl LiveDOMReferences {
     /// ptr must be a pointer to a type that implements DOMObject.
     /// This is not enforced by the type system to reduce duplicated generic code,
     /// which is acceptable since this method is internal to this module.
+    #[allow(clippy::arc_with_non_send_sync)]
     unsafe fn addref(&self, ptr: *const libc::c_void) -> Arc<TrustedReference> {
         let mut table = self.reflectable_table.borrow_mut();
         let capacity = table.capacity();

components/script/dom/closeevent.rs

@@ -37,6 +37,7 @@ impl CloseEvent {
         }
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         global: &GlobalScope,
         type_: Atom,

components/script/dom/compositionevent.rs

@@ -35,6 +35,7 @@ impl CompositionEvent {
         reflect_dom_object(Box::new(CompositionEvent::new_inherited()), window)
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         window: &Window,
         type_: DOMString,

python/servo/gstreamer.py

@@ -182,7 +182,7 @@ def write_plugin_list(target):
         plugins = windows_plugins()
     print('''/* This is a generated file. Do not modify. */
 
-pub(crate) static GSTREAMER_PLUGINS: &[&'static str] = &[
+pub(crate) static GSTREAMER_PLUGINS: &[&str] = &[
 %s
 ];
 ''' % ',\n'.join(map(lambda x: '"' + x + '"', plugins)))