Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we include the Eslint rules override from @typescript-eslint/eslint-recommended ? #23

Open
pvdlg opened this issue Mar 25, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pvdlg
Copy link

pvdlg commented Mar 25, 2020

The @typescript-eslint/eslint-plugin provides a recommended config which turn off some Eslint rules that conflicts or doesn't work well with TypeScript.

For example in a types.d.ts file with the following code:

type MyType = {};

export {MyType};

the rules rule no-undef is incorrectly triggered.

I think this config is the right place to disable those rules. We could even just include plugin:@typescript-eslint/eslint-recommended here.

What do you think @sindresorhus ?

@pvdlg pvdlg changed the title Should we include the Eslint rule override from @typescript-eslint/eslint-recommended ? Should we include the Eslint rules override from @typescript-eslint/eslint-recommended ? Mar 25, 2020
@sindresorhus
Copy link
Member

I think this config is the right place to disable those rules. We could even just include plugin:@typescript-eslint/eslint-recommended here.

👍

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants