Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vox doesn't expand ~ for $VIRTUALENV_HOME #2

Open
jaraco opened this issue Dec 21, 2021 · 3 comments
Open

vox doesn't expand ~ for $VIRTUALENV_HOME #2

jaraco opened this issue Dec 21, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jaraco
Copy link

jaraco commented Dec 21, 2021

Setting $VIRTUALENV_HOME to ~/.local/envs causes environments to be created in ~/\~/.local/envs (e.g. /Users/username/~/.local/envs). It would be nice if one didn't have to call os.expanduser when setting the environment variable.

@anki-code anki-code added the good first issue Good for newcomers label Dec 21, 2021
@gforsyth
Copy link

gforsyth commented Jan 5, 2022

I'd wager this is the culprit if anyone wants to take a crack at it: https://github.com/xonsh/xonsh/blob/c01fc6efe37bbd314779e62f80f9de598b9680bc/xontrib/voxapi.py#L132-L133

@anki-code
Copy link
Member

Hi @yaxollum! Thanks for the fix in xonsh/xonsh#4713! Could you please take a look into this similar issue?

@yaxollum
Copy link
Member

Hi @anki-code! This does look like a very similar issue (something like expand_path(XSH.env["VIRTUALENV_HOME"]) would probably fix it), but I'm not familiar with Python virtual environments, so it would be nice if someone experienced with virtual environments could fix this and test it out.

@anki-code anki-code transferred this issue from xonsh/xonsh Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants