-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the component work with any UI library #10
Comments
+1 |
Hi, sorry for the late (late) answer. Thank you very much, I appreciate that you like this component. I also think it can be a great improvement to let anyone used this component without Ant Design. I just didn't take the time (yet) to do this. I think I will take a look to see what's possible, maybe even not using a UI library at all with plain CSS, so everyone can use it. I just don't want to lose any features. Anyway, It can really help to do that because today this component depends a lot on antd. When they make breaking changes, it can break the component. I will try to keep you posted if I make any development on my side. |
@xrutayisire Hi! Thanks a lot for this cron lib, but it seems like it's time to do something with using antd :) According to this thread, antd does not works properly with react 18 and I can't see any activity of antd team to fix this. So your library doesn't works with react 18 too. Is there any chance to get rid of antd? |
Hi! Thanks for your comment, I didn't know about React 18 crash. I will check and see if it's still working on my side. Btw I think I just deactivated StrictMode. And to get rid of antd it requires a lot of work to keep the same UI. I wanted to start the dev, but I didn't have the time. |
@xrutayisire I'd be happy to assist you. Let's plan and start the development. |
I just emailed you, so we can plan a call together. |
For what it's worth, as in interim solution, I copied the |
Any chance to get only the minimal style to use the component ? It adds like The component might be called |
I have a workaround for the CSS, you only need to grab It drops to |
Yes it is because of antd, not the style from this library. So it cannot be done from the lib. |
Is your feature request related to a problem? Please describe.
This is the best cron generator I've found, but my project uses material UI. I think it'd be great if it can work without
antd
.Describe the solution you'd like
We could modify it to pass in the Button component & the Select component. Or maybe, carve out the core logic so that one can use it even without using the default UI and by just passing in the required props.
I'd be happy to contribute once we figure out a plan.
Thank you so much for this library!
The text was updated successfully, but these errors were encountered: