Action links on BuddyPress logs are incorrect on multisite

[tharsheblows]

Bug Report

The action links on BuddyPress log entries do not link to the correct site on the Network Stream log.

Expected Behavior

They should link to the correct site.

Actual Behavior

They link to the site the network is on.

Steps to Reproduce the Problem

1. Create two sites in multisite
2. Network activate Stream
3. Enable BuddyPress on both
4. Go to the Network Stream log and look at the action links under the "Summary" in each entry. They will be incorrect for any entries who are not from the network domain.

Screenshots

(Testy Site url is stream.wpenv.net/testy)

[tharsheblows]

There are various ways Stream and BuddyPress can be activated in a multisite.

BuddyPress

These are outlined here.

• Network activated:
  • BuddyPress root blog is the main site where the network admin is
  • BuddyPress root blog is not the main site
• Not network activated
  • on a blog
  • not on a blog

(nb: I know the last two are obvious but they're needed for record keeping 😊)

Stream

• Network activated (always on main site with network admin)
  • Site access enabled, all sites can see their own Stream logs
  • Site access disabled
• Enabled on a single site only

For Stream, testing the network admin logs as well as the individual site logs is be enough.

So let's test these scenarios:

• BuddyPress network activated root blog is the main site
• Stream network activated in the network admin
• Stream activated on the root blog
• BuddyPress root blog is not the main site
• Stream network activated in the network admin
• Stream activated on the site on which BuddyPress has set as the root blog
• Stream activated on a site where BuddyPress is not activated (mainly for completeness)

Note regarding the tests above: if you are viewing the Stream logs as an admin of a site in a multisite and are not a super admin, you can't edit BuddyPress so the action links will not be shown.

• BuddyPress is not network activated but is activated on one site
• Stream network activated in the network admin
• Stream activated on a site where BuddyPress is activated
• Stream activated on a site where BuddyPress is not activated (it doesn't show up, this is correct)

The BuddyPress connector won't add links if the functions used to generate them aren't available (see #1517 ) so in the network admin area, if BuddyPress is not network activated, the expectation is that there won't be action links before the log entries. This is acceptable.