Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using React 16 and Portals with Flickity #16

Closed
ryanwiemer opened this issue Dec 6, 2017 · 2 comments
Closed

Using React 16 and Portals with Flickity #16

ryanwiemer opened this issue Dec 6, 2017 · 2 comments

Comments

@ryanwiemer
Copy link

ryanwiemer commented Dec 6, 2017

@theolampert

I can't say I have tested this myself but have you taken a look at this comment on the flickity repo regarding React 16 and portals?

metafizzy/flickity#488 (comment)

I'm just curious if that is relevant to your code here or if the approach that you have taken has pros/cons that make it a better choice.

Thanks,
Ryan

@theolampert
Copy link
Collaborator

Hey @ryanwiemer I have seen this and as of React 16 this would definitely be the way to go. I just haven't had a heap of time to look into this recently but imagine following the example codepen here would be an excellent starting point for a proof of concept: https://codepen.io/smartmike/pen/dZBNVv. Would you or anyone else be willing to submit a WIP PR?

@yaodingyd
Copy link
Owner

@theolampert This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants