#375 semi-colon to end each cookie line in Set-Cookie

Author: Yegor Bugayenko

src/main/java/org/takes/rs/RsWithCookie.java

@@ -147,9 +147,9 @@ private static String make(final String previous, final CharSequence name,
         if (!previous.isEmpty()) {
             text.append(String.format("%s,", previous));
         }
-        text.append(String.format("%s=%s", name, value));
+        text.append(String.format("%s=%s;", name, value));
         for (final CharSequence attr : attrs) {
-            text.append(';').append(attr);
+            text.append(attr).append(';');
         }
         return text.toString();
     }

src/test/java/org/takes/facets/flash/TkFlashTest.java

@@ -54,7 +54,7 @@ public void removesFlashCookie() throws IOException {
                     "Cookie: RsFlash=Hello!"
                 )
             ).head(),
-            Matchers.hasItem("Set-Cookie: RsFlash=")
+            Matchers.hasItem("Set-Cookie: RsFlash=;")
         );
     }
 }

src/test/java/org/takes/facets/ret/TkReturnTest.java

@@ -56,7 +56,7 @@ public void redirectsAndRemovesCookie() throws IOException {
                 new RqWithHeader(
                     new RqFake(),
                     String.format(
-                        "Cookie: RsReturn=%s",
+                        "Cookie: RsReturn=%s;",
                         URLEncoder.encode(
                             destination,
                             Charset.defaultCharset().name()
@@ -67,7 +67,7 @@ public void redirectsAndRemovesCookie() throws IOException {
             Matchers.contains(
                 "HTTP/1.1 303 See Other",
                 String.format("Location: %s", destination),
-                "Set-Cookie: RsReturn="
+                "Set-Cookie: RsReturn=;"
             )
         );
     }

src/test/java/org/takes/rs/RsWithCookieTest.java

@@ -54,7 +54,7 @@ public void addsCookieToResponse() throws IOException {
             Matchers.equalTo(
                 Joiner.on("\r\n").join(
                     "HTTP/1.1 200 OK",
-                    "Set-Cookie: foo=works?;Path=/",
+                    "Set-Cookie: foo=works?;Path=/;",
                     "",
                     ""
                 )
@@ -83,7 +83,7 @@ public void addsMultipleCookies() throws IOException {
                 Joiner.on("\r\n").join(
                     "HTTP/1.1 200 OK",
                     // @checkstyle LineLengthCheck (1 line)
-                    "Set-Cookie: foo=works?;Path=/,bar=worksToo?;Path=/2nd/path/",
+                    "Set-Cookie: foo=works?;Path=/;,bar=worksToo?;Path=/2nd/path/;",
                     "",
                     ""
                 )
@@ -93,19 +93,17 @@ public void addsMultipleCookies() throws IOException {
 
     /**
      * RsWithCookie can reject invalid cookie name.
-     * @throws IOException If some problem inside
      */
     @Test(expected = IllegalArgumentException.class)
-    public void rejectsInvalidName() throws IOException {
+    public void rejectsInvalidName() {
         new RsWithCookie(new RsEmpty(), "f oo", "works");
     }
 
     /**
      * RsWithCookie can reject invalid cookie value.
-     * @throws IOException If some problem inside
      */
     @Test(expected = IllegalArgumentException.class)
-    public void rejectsInvalidValue() throws IOException {
+    public void rejectsInvalidValue() {
         new RsWithCookie(new RsEmpty(), "bar", "wo\"rks");
     }
 }