Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: drop github-username dependency. #1604

Open
mshima opened this issue Feb 20, 2025 · 3 comments
Open

Breaking: drop github-username dependency. #1604

mshima opened this issue Feb 20, 2025 · 3 comments
Labels
needs triage Awaiting triage

Comments

@mshima
Copy link
Member

mshima commented Feb 20, 2025

I don’t think github-username is useful enough to worth 6,5MB.

@mshima mshima added the needs triage Awaiting triage label Feb 20, 2025
@mshima
Copy link
Member Author

mshima commented Feb 20, 2025

What do you think @UlisesGascon @JoshuaKGoldberg?

@JoshuaKGoldberg
Copy link

Heh, yeah, the package bringing in all of @octokit/rest seems a bit much. There's only one place I see it being used:

/**
* Retrieves GitHub's username from the GitHub API
* @return Resolved with the GitHub username or rejected if unable to
* get the information
*/
username: async () => {
const email = await this.git.email();
return email ? githubUsername(email) : email;
},

Since it's not using the token option, and so is purely an anonymous API call, I think we could just call the API manually. 👍 from me, would like to hear @UlisesGascon's opinion too.

@UlisesGascon
Copy link
Member

@octokit/rest seems the way to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Awaiting triage
Projects
None yet
Development

No branches or pull requests

3 participants