Update github-username to 9.0.0 to fix security vulnerability #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
What changes did you make?
Updated
github-usernameto the latest major version, 9.0.0 - it fixes a transitive dependency on@octokit/rest, which was vulnerable to a regular expression denial of service. See sindresorhus/github-username#15 and octokit/rest.js#484.Is there anything you'd like reviewers to focus on?
Just to make sure there aren't any regressions, but the only breaking changes in
github-usernameshould be dropping support for Node 16, which this package has already done. Because of that, I don't believe this should need a major version update.