-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed videos/images navigation issues #32
Comments
I invited you as collaborator of this library. If you are not mind, we can make this library together :) |
@younatics Thanks! I'm pretty busy with other projects, but I'll try to help whenever I can. I'm planning to integrate the library into an app with a couple of hundred thousand users per month, so it'll be in my own interest to iron out bugs and improve the lib... |
you can accept my invite, and I will help you with my best. Thanks! |
@younatics I've added a public convenience init(videoURL: URL, previewImageURL: URL? = nil) {
self.init()
self.videoURL = videoURL
isVideo = true
emptyImage = (previewImageURL == nil) ? true : false
self.photoURL = previewImageURL
} Please take a look at the corresponding branch. However, I haven't figured out what is causing the scrolling issue yet. Maybe you could take a look and see if you can fix it? |
@weakfl I updated your commit and I will check how to fix it ASAP... |
If videos and images are used together the UIPageViewController navigation has issues (see attached video). To reproduce the issue just add an image to the "Web videos" demo.
Also it would be nice if the corresponding thumb would be displayed beneath the play button instead of the error image.
mixed_video_images.mp4.zip
The text was updated successfully, but these errors were encountered: