Refactored.

Author: ynn

coefont/coefont.go

@@ -28,10 +28,11 @@ type Common struct {
 
 func APICall(req Request, common Common, resultChannel chan<- string) {
 
+	defer close(resultChannel)
+
 	var requestBody, err = json.Marshal(req)
 	if err != nil {
 		log.Printf("Failed to jsonalize the request body: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 
@@ -46,7 +47,6 @@ func APICall(req Request, common Common, resultChannel chan<- string) {
 	request, err := http.NewRequest(http.MethodPost, common.URL, bytes.NewReader(requestBody))
 	if err != nil {
 		log.Printf("Failed to create a first POST request: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 	request.Header.Add("Content-Type", "application/json")
@@ -66,15 +66,13 @@ func APICall(req Request, common Common, resultChannel chan<- string) {
 	response, err := client.Do(request)
 	if err != nil {
 		log.Printf("Failed to send a first POST request: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 	defer response.Body.Close()
 	if response.StatusCode != http.StatusFound {
 		log.Printf("The response isn't 302 Found.\n")
 		// b, _ := io.ReadAll(response.Body)
 		// log.Println(string(b))
-		resultChannel <- ""
 		return
 	}
 
@@ -83,37 +81,32 @@ func APICall(req Request, common Common, resultChannel chan<- string) {
 	request, err = http.NewRequest(http.MethodGet, redirectURL /* body = */, nil)
 	if err != nil {
 		log.Printf("Failed to create a second GET request: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 	response, err = client.Do(request)
 	if err != nil {
 		log.Printf("Failed to send a second GET request: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 	defer response.Body.Close()
 
 	content, err := io.ReadAll(response.Body)
 	if err != nil {
 		log.Printf("Failed to read the request body of a second GET request: %v\n", err)
-		resultChannel <- ""
 		return
 	}
 
 	var filename = fmt.Sprintf("%v/%v_%v.wav", common.OutputDir, currentTime, req.Text)
 	file, err := os.Create(filename)
 	if err != nil {
 		log.Printf("Failed to create the file [ %v ]: %v\n", filename, err)
-		resultChannel <- ""
 		return
 	}
 	defer file.Close()
 
 	_, err = file.Write(content)
 	if err != nil {
 		log.Printf("Failed to write to the file [ %v ]: %v\n", filename, err)
-		resultChannel <- ""
 		return
 	}
 

lint.sh

@@ -2,6 +2,7 @@
 
 set -x
 
+find . -name '*.out' -delete &&
 go fmt ./... &&
 go vet ./... &&
 golint ./... | grep --color=never -v -e 'exported type .* should have comment or be unexported' -e 'exported function .* should have comment or be unexported'