New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLfluff lint fails, but workflow passed #39

Open

XiChu2333 opened this issue Jul 21, 2022 · 0 comments

XiChu2333 commented Jul 21, 2022

The exit code is wrong for running SQLFluff lint: it return 0 even if the SQLFluff lint raises an exception.

It's because the sqlfluff_exit_code get the wrong code from "tee" command.
https://github.com/yu-iskw/action-sqlfluff/blob/main/entrypoint.sh#:~:text=%24changed_files%20%7C-,tee%20%22%24lint_results%22,-sqlfluff_exit_code%3D%24%3F
I can give a PR for fixing this.

XiChu2333 mentioned this issue

fix wrong lint exit code #40

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment