Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Avoid leaking subtree affinity for found notes #1737

Open
nuttycom opened this issue Mar 12, 2025 · 0 comments
Open

zcash_client_backend: Avoid leaking subtree affinity for found notes #1737

nuttycom opened this issue Mar 12, 2025 · 0 comments

Comments

@nuttycom
Copy link
Contributor

At present, when performing out-of-order scanning, finding a note results in a FoundNote priority range being inserted into the scan queue. This priority range likely has a different size than the default scan chunk size, and as a consequence the light wallet server can distinguish which subtrees have notes belonging to the wallet. Up until now, we haven't worried about this too much, because the memo retrieval has leaked much more information about which transactions the wallet is interested in. However, with transaction retrieval moving to requests performed over Tor, this now becomes an important metadata leak to the lightwalletd server.

A good solution to this is to make scan retrieval ranges uniformly sized and uniformly distributed over the shards, and scanning should also probably be performed in random order. When this change is made, we should also verify that the scan ranges introduced by zcash_client_sqlite::wallet::commitment_tree::check_witnesses (see #1709) are not distinguishable from ordinary scanning operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant