Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer IO#wait_readable and IO#wait_writable where possible. #977

Open
samuel-williams-shopify opened this issue Mar 26, 2025 · 0 comments
Open

Prefer IO#wait_readable and IO#wait_writable where possible. #977

samuel-williams-shopify opened this issue Mar 26, 2025 · 0 comments

Comments

@samuel-williams-shopify
Copy link

There are several instances of IO.select with a single file descriptor. It is better to use IO#wait_readable or IO#wait_writable` because it is more efficient internally.

ruby-kafka/lib/kafka/socket_with_timeout.rb

Line 40 in 62a0cf9

unless IO.select(nil, [@socket], nil, connect_timeout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samuel-williams-shopify