Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensors: rtio No error reporting from bus controller to application #81014

Open
FlorianWeber1018 opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels
area: RTIO bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@FlorianWeber1018
Copy link
Contributor

FlorianWeber1018 commented Nov 6, 2024

Is your enhancement proposal related to a problem? Please describe.

If a sensor uses a bus controller with the RTIO there is at the moment no possibility to inform the application if a action of the bus controllers fails. Reporting on success an the moment is implemented with callbacks.
If a sqe to the bus controller fails, the callback won´t be called and the sqe to the sensor never produce a cqe.
A example how a sensor driver uses a bus controller with the rtio could be
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/sensor/adi/adxl362/adxl362_stream.c#L234-L246

Describe the solution you'd like

That the RTIO provides any mechanism to get the cqes of sqes in an asynchrounous way.
If we stay on the callback solution for reporting an ok on success at the bus controller, we should at least give the sqes an option to redirect their errors so a different RTIO.

Additional context

Thread: https://discord.com/channels/720317445772017664/1302974460789522523
after Message https://discord.com/channels/720317445772017664/1302974460789522523/1303736670922739767

@FlorianWeber1018 FlorianWeber1018 added the Enhancement Changes/Updates/Additions to existing features label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Hi @FlorianWeber1018! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@teburd
Copy link
Collaborator

teburd commented Nov 6, 2024

@bperseghetti @jgoppert this likely relates to the issue with rtio and cognipilot as well

@teburd teburd added bug The issue is a bug, or the PR is fixing a bug area: RTIO labels Nov 6, 2024
@mmahadevan108 mmahadevan108 added priority: low Low impact/importance bug and removed Enhancement Changes/Updates/Additions to existing features labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RTIO bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants