Skip to content

Commit 7ac6764

Browse files
committed
addressing issues stefan-jansen#137, 138, 135, 134, 132
1 parent e7d1a18 commit 7ac6764

File tree

3 files changed

+405
-102
lines changed

3 files changed

+405
-102
lines changed

02_market_and_fundamental_data/04_sec_edgar/edgar_xbrl.ipynb

+4-4
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
" path = data_path / f'{yr}_{qtr}' / 'source'\n",
180180
" if not path.exists():\n",
181181
" path.mkdir(exist_ok=True, parents=True)\n",
182-
" url = SEC_URL + FSN + filing\n",
182+
" url = SEC_URL + FSN_PATH + filing\n",
183183
" \n",
184184
" # 2020q1 is currently (Oct 2020) in a different location; this may change at some point\n",
185185
" if year == 2020 and q == 1:\n",
@@ -2921,9 +2921,9 @@
29212921
],
29222922
"metadata": {
29232923
"kernelspec": {
2924-
"display_name": "Python [conda env:ml4t]",
2924+
"display_name": "Python [conda env:root] *",
29252925
"language": "python",
2926-
"name": "conda-env-ml4t-py"
2926+
"name": "conda-root-py"
29272927
},
29282928
"language_info": {
29292929
"codemirror_mode": {
@@ -2935,7 +2935,7 @@
29352935
"name": "python",
29362936
"nbconvert_exporter": "python",
29372937
"pygments_lexer": "ipython3",
2938-
"version": "3.7.7"
2938+
"version": "3.8.8"
29392939
},
29402940
"toc": {
29412941
"base_numbering": 1,

installation/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
This book uses (mostly) Python 3.7 and various ML- and trading-related libraries available in three different [conda environments](https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html) based on the [Miniconda](https://docs.conda.io/en/latest/miniconda.html) distribution. I developed the content on Ubuntu 20.04 while also testing on Mac OS 10.15 (Catalina).
44

5+
> Update: I have just released a [new Zipline version](https://github.com/stefan-jansen/zipline-reloaded) that runs on Python 3.7-3.9; see [release info](https://github.com/stefan-jansen/zipline-reloaded/releases/tag/2.0.0rc4) and [docs](https://zipline.ml4trading.io/). As a result, the Docker solution will no longer be necessary going forward and I will provide new environment files over the course of April.
6+
57
> Update: Release 2.0 reduces the number of environments to 2 and bumps the Python version to 3.8 for the main `ml4t` and to 3.6 for the `backtest` environment.
68
> Instructions below reflect these changes.
79

0 commit comments

Comments
 (0)