Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if zowe.*Directory is not nested in zowe.runtimeDirectory #243

Open
Martin-Zeithaml opened this issue Aug 20, 2024 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Martin-Zeithaml
Copy link

Schema validation is checking, if the directories used for Zowe are valid USS paths. But that's not sufficient, user can define e.g. zowe.logDirectory (or other directories) "inside" zowe.runtimeDirectory.
This is not good for couple reasons:

  • We recommend to set zowe.runtimeDirectory as read-only
  • zwe support will detect new files when calculating fingerprints
    • This is reported even the original files are fine

Such setting should invoke (at least) a warning:

zowe:
  runtimeDirectory: /global/zowe
  logDirectory: /global/zowe/logs
  workspaceDirectory: /global/zowe/workspace
  extensionDirectory: /global/zowe/extensions

There are more directories used, like java, node, certificates, but the check for the directories in the example should be fine.

@skurnevich
Copy link
Collaborator

I'v added a basic warning as part of this PR
But it could be done in a better way, so lets keep this task as open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants