Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing profile editing #216

Closed
wants to merge 2 commits into from
Closed

Implementing profile editing #216

wants to merge 2 commits into from

Conversation

hunterlan
Copy link
Contributor

⏱️ Before you start

  • [ x ] Have you checked if a similar PR has already been requested?
  • [ x ] Have you built and ran the app?

↗️ Related/Fixed issues

📄 Description

Implemented edit profile. Added a vertical scroll bar and email field.

💭 Motivation and Context

This PR will solve issue #215

📸 Assets (if appropriate):

image

I added initialization for properties, where it should be.
@0x5bfa
Copy link
Owner

0x5bfa commented Jul 28, 2022

We don't implement those features until the app gets v0.5. Besides, we use Octokit.GraphQL.NET instead of Octokit.NET

I'm sorry

@0x5bfa
Copy link
Owner

0x5bfa commented Jul 28, 2022

But you can still remain this.

@hunterlan
Copy link
Contributor Author

We don't implement those features until the app gets v0.5.

But why? And what should be implemented for now, and what shouldn't?

@0x5bfa
Copy link
Owner

0x5bfa commented Jul 29, 2022

Actually we have loadmap.

-v0.5 Completely implemented all of querying feature without harmful bugs.
-v0.9 Completely implemented all of mutation features without harmful bugs.
-v1.0 Final checking and fix all of issues on GitHub.

*Querying: get data from GitHub though Octokit API(prefer Octokit.GraphQL.NET to Octokit.NET).
*Mutation: set data to GitHub though Octokit API(prefer Octokit.GraphQL.NET to Octokit.NET).

And ship stable version - FluentHub v1, deleted DEV or something ugly label.

@0x5bfa
Copy link
Owner

0x5bfa commented Jul 29, 2022

But I'm not sure it is a good idea. I think these days that we should implement some of mutation feature.

@0x5bfa 0x5bfa added area-user change requested This PR has had requested changes. labels Aug 1, 2022
@0x5bfa 0x5bfa closed this Aug 4, 2022
@0x5bfa 0x5bfa removed change requested This PR has had requested changes. priority-low labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement editing basic user information
2 participants