Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: P2A input and output detection #26

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

andrewtoth
Copy link
Contributor

No description provided.

Copy link
Owner

@0xB10C 0xB10C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ACK. Thanks for adding this!

src/output.rs Outdated
Comment on lines 205 to 206
&& script_pubkey_bytes[2] == 78u8
&& script_pubkey_bytes[3] == 115u8;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
&& script_pubkey_bytes[2] == 78u8
&& script_pubkey_bytes[3] == 115u8;
&& script_pubkey_bytes[2] == 0x4eu8
&& script_pubkey_bytes[3] == 0x73u8;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. If you release I can update transactionfee-info.

@0xB10C 0xB10C merged commit 0572439 into 0xB10C:master Feb 3, 2025
1 check passed
@andrewtoth andrewtoth deleted the p2a branch February 3, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants