Edited Examples to Run By CI Pipeline #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple files to pipeline.
…or. Edited GitHub Secret names to match.
MOmarMiraj
requested changes
Mar 6, 2025
Comment on lines
+37
to
+49
| - name: Run esm-example | ||
| if: matrix.os == 'ubuntu-latest' | ||
| env: | ||
| OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.EXAMPLE_TESTS_OP_SERVICE_ACCOUNT_TOKEN }} | ||
| OP_VAULT_ID: ${{ secrets.EXAMPLE_TESTS_OP_VAULT_ID }} | ||
| run: npm run esm-example | ||
|
|
||
| - name: Run commonjs-example | ||
| if: matrix.os == 'ubuntu-latest' | ||
| env: | ||
| OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.EXAMPLE_TESTS_OP_SERVICE_ACCOUNT_TOKEN }} | ||
| OP_VAULT_ID: ${{ secrets.EXAMPLE_TESTS_OP_VAULT_ID }} | ||
| run: npm run commonjs-example |
There was a problem hiding this comment.
Same as Go and Python comment here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered logic in
examples/index.cjsandexamples/index.mjsto read the previously hardcodedvault_idfrom environment variables.Added
examples/index.cjsandexamples/index.mjsto the validation workflow, and readOP_SERVICE_ACCOUNT_TOKENandOP_VAULT_IDfrom GitHub secrets.Altered the example
client.secrets.resolveto resolve field from item created during the item CRUD in bothexamples/index.cjsandexamples/index.mjs.