Increased Team Sizes (ITS) #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint8 -> uint16
Fix an access to member variable that prevented compilation
Fix missing variable declaration
Pressing Shift and right or left arrow buttons, 'a' or 'd' buttons, or previous or next ingame buttons now advance one whole page. Without shift pressed down, all three function as original and move one merc at a time.
Unimplemented feature of browsing 4 mercs forward/backwards in personnel page.
ubEnemyKilledOnAttacker is size UINT16 but loading function was reading only UINT8 worth for it
As per the old comment, even though the field value is updated partially according to whether there are known enemies present or not, it's not used for anything.
Goal is to convert all use of SOLDIERTYPE->ubID and any other ID fields that reference the same ID to a safer type than UINT16. Same with any function that's supposed to take ubID
All raw array accesses should be done with these instead.
One less for loop that way
Fixed if conditions as well SOLDIERTYPE::ubProfile would never match with values above NOBODY
Remnant from the initial branch commit
Requires new file OverheadInterface_scrollarea.sti in Gamedir/Data/Interface/
Merc names were being printed past the end of teamlist area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKS SAVEGAME COMPATIBILITY
Change SOLDIERTYPE ubID to UINT16, lifting the restrictions on max amount of mercs, enemies, civs, creatures in tactical mode.