Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to include openai #759

Closed
wants to merge 1 commit into from

Conversation

maxvonhippel
Copy link

While conducting a fuzz campaign for Benchify I noticed that you appear to be missing an import for OpenAI, which you use in llm.py. This PR fixes that omission.

While conducting a fuzz campaign for [Benchify](https://www.benchify.com) I noticed that you appear to be missing an import for OpenAI, which you use in [llm.py](https://github.com/2noise/ChatTTS/blob/8fcc0cd6ae162ff8f2d65a2b355aaafb47d7e9e8/tools/llm/llm.py#L1).  This PR fixes that omission.
@github-actions github-actions bot changed the base branch from main to dev September 18, 2024 17:04
@fumiama
Copy link
Member

fumiama commented Sep 21, 2024

Well, it is missed intentionally because this is not a necessary import. Instead of adding this to the requirements.txt, you can add the usage instruction of llm.py in README and let user to install this package manually.

@fumiama fumiama added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Sep 21, 2024
@fumiama fumiama closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants