Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid usage of == operator #465

Open
wants to merge 5 commits into
base: main-cris
Choose a base branch
from

Conversation

saschaszott
Copy link

Description

This fix is inspired by the finding mentioned in a comment of Github issue DSpace/dspace-angular#2004 (comment)

@saschaszott
Copy link
Author

@jor4science, this is not production-critical but easy to merge.

@jor4science
Copy link

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott .
Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@saschaszott
Copy link
Author

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott . Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@jor4science , could you clarify how this would work? The PRs affect both the Angular frontend and the Java backend.

@jpiscanc
Copy link

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott . Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@jor4science , could you clarify how this would work? The PRs affect both the Angular frontend and the Java backend.
You're right. My fault. Obviously collect Java backend:
this PR with AccountServiceImpl : resolve merge conflicts in Javadoc comments #484

I'm adding the comment on Angular added German translations #39 side.
Thanks

@saschaszott
Copy link
Author

saschaszott commented Mar 14, 2025

@jor4science : done (backend part)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants