Wip prevent highlight if outside of canvas #6092
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSi
reviewed
Jan 5, 2024
| renderedInstance._pixiObject.addEventListener('mouseover', event => { | ||
| console.log('mouseover', event); | ||
| if ( | ||
| shouldPreventRenderingInstanceEditors() || |
There was a problem hiding this comment.
I don't think it's reasonable to check on each frame if there's dialog open (DOM query). I think it should at least be cached for the current frame.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #6067
It solves the fact that items are still highlighted when mouse is outside of the canvas, but not the fact that it gets highlighted on the frame it is deleted.