Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade bondage to the yarn 2 spec - closes 6451 #6466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blurymind
Copy link
Contributor

@blurymind blurymind commented Mar 18, 2024

The new bondagejs appears to be imported correctly (see logging)

When trying to run my old test demo game however I get this error

image
image

@4ian @Silver-Streak any idea why this is happening? Is it something to do with how the umd module is configured?
This was one of the major things that the contributor did to modernize it. He migrated it from rollup/gulp to webpack
https://github.com/hylyh/bondage.js/blob/master/gulpfile.js
https://github.com/hylyh/bondage.js/blob/2.0/webpack.config.js

trying to address #6451

  • fix new library import breaks the extension/runtime
  • do extensive testing with existing projects

closes 6451 if I can ever figure out why the import no longer works in gdevelop

@blurymind blurymind requested a review from 4ian as a code owner March 18, 2024 20:09
@blurymind blurymind changed the title upgrade bondage to the yarn 2 spec upgrade bondage to the yarn 2 spec - closes 6451 Mar 20, 2024
@Silver-Streak
Copy link
Collaborator

Silver-Streak commented Mar 21, 2024

I'm not much help here, sadly. Without a stacktrace I can't even help research.

Bad end of line in the console makes it seem like something somewhere is not escaped properly, but I'm not sure.

I'd be looking at maybe @D8H for input if not @4ian

@blurymind
Copy link
Contributor Author

guess if you run Gdevelop with the dialogue tree project - with this branch you will see the stack and it is not helpful at all.

It appears to get an exception at the second screenshot i made

@blurymind
Copy link
Contributor Author

blurymind commented Mar 22, 2024

I just noticed the developer who upgraded this in a PR has a branch that is slightly ahead from the pr he made
https://github.com/mnbroatch/bondage.js/commits/master/
https://www.npmjs.com/package/@mnbroatch/bondage
I will try using the version from his branch instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to the newest bondagejs or replace bondagejs with YarnSpinner-rust
2 participants