Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate internal actions and conditions to set and compare property values #7405

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Deprecate internal actions and conditions to set and compare property values #7405

wants to merge 4 commits into from

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Feb 16, 2025 •
edited
Loading

  • Also deprecate conditions to compare parameter values
  • The action and condition to set and compare variables must be used instead
  • Generated getter and setter now use the new system

These instruction were kept as a workaround in case of issue in the code generation of variable instructions. 20 migrated extensions has been tested on 4 examples.

D8H added 2 commits February 16, 2025 12:49
@D8H
Deprecate internal actions and conditions to set and compare property…
3364a8e 
… values

- Also deprecate conditions to compare parameter values
- The action and condition to set and compare variables must be used instead
@D8H
Generate getter and setter using the new system.
46dff24
@D8H D8H marked this pull request as ready for review February 16, 2025 15:26
@D8H D8H requested a review from 4ian as a code owner February 16, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ian 4ian Awaiting requested review from 4ian 4ian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@D8H