Refresh in app tutorial message in preview when hot reloading preview #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Feb 17, 2025
| @@ -108,7 +109,7 @@ namespace gdjs { | |||
| .then((fontFace) => document.fonts.add(fontFace)); | |||
| }; | |||
|
|
|||
| const _loadStyles = () => { | |||
| const _loadStyleSheet = () => { | |||
| const adhocStyle = document.createElement('style'); | |||
There was a problem hiding this comment.
Should you store a reference to it to avoid re-creating it each time _loadStylesheet is called?
4ian
reviewed
Feb 17, 2025
| containerPositionStyle, | ||
| messageContainerPositionStyle, | ||
| } = _getPositioningStyle(position); | ||
|
|
||
| _loadFonts(); |
There was a problem hiding this comment.
Maybe make this method do nothing if fonts are already loaded.
4ian
reviewed
Feb 17, 2025
| @@ -108,7 +109,7 @@ namespace gdjs { | |||
| .then((fontFace) => document.fonts.add(fontFace)); | |||
There was a problem hiding this comment.
You can async/await and set a boolean when finished
4ian
reviewed
Feb 17, 2025
| @@ -174,6 +176,17 @@ namespace gdjs { | |||
| const newRuntimeGameOptions: RuntimeGameOptions = | |||
| gdjs.runtimeGameOptions; | |||
|
|
|||
| this._runtimeGame._displayMessageInPreview = | |||
There was a problem hiding this comment.
I'm a bit uneasy at this patching of a private variable + patching of _options.
Could we rather call a method, like runtimeGame.displayInAppTutorialMessage(...)?
4ian
reviewed
Feb 17, 2025
GDJS/Runtime/runtimegame.ts
Outdated
| @@ -191,6 +191,7 @@ namespace gdjs { | |||
| _sessionMetricsInitialized: boolean = false; | |||
| _disableMetrics: boolean = false; | |||
| _isPreview: boolean; | |||
| _displayMessageInPreview: boolean = false; | |||
There was a problem hiding this comment.
This boolean is a bit weird, it acts as "show it once" but it's not super clear when reading its name.
Do we really need it?
AlexandreSi
force-pushed
the
in-preview-messages-reload
branch
from
601c54d to
9949711
Compare
AlexandreSi
force-pushed
the
in-preview-messages-reload
branch
from
9949711 to
6acdaf9
Compare
4ian
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.