fixed build issue with aosp master branch #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix based on: https://android-git.linaro.org/device/linaro/dragonboard410c.git/commit/?h=dragonboard&id=dbe30cae1ef227860089e1840aeb1cd140c0003a hostapd: Add HIDL interface and remove deprecated sepolicies Add hostapd HIDL interface and remove deprecated hostapd sepolicies since AOSP no longer have a predefined hostapd domain and we run into "ERROR 'unknown type hostapd'" build error instead. Signed-off-by: Sahaj Sarup <[email protected]>
|
Requesting review @docularxu |
|
Forgive me being didactic but do the resulting binaries boot to GUI? |
|
@daniel-thompson I just checked, it's not booting to GUI for me. So this just fixes the build. |
|
On Wed, 26 Dec 2018 at 11:06, Sahaj Sarup ***@***.***> wrote:
@daniel-thompson I just checked, it's not booting to GUI for me. So this just fixes the build.
Adding boot log for reference https://pastebin.com/1cxL415C
init: [libfs_mgr]fs_mgr_read_fstab_dt(): failed to read fstab from dt
init: Failed to read fstab from device tree
init: [libfs_mgr]fs_mgr_read_fstab_default(): failed to find device
default fstab
init: [libfs_mgr]fs_mgr_read_fstab_dt(): failed to read fstab from dt
init: First stage mount skipped (missing/incompatible/empty fstab in
device tree)
This ^^ is a fatal error. Fstab DT entries are no longer optional.
Ref:
https://android-git.linaro.org/device/linaro/dragonboard410c.git/commit/?h=dragonboard&id=9b534d9c5e24656c680f029f144e4e4a08f2899f
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=release/android/qcomlt-4.14&id=7f14045de13cd7e73030e11368fd193a4efc5db9
…
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix based on:
https://android-git.linaro.org/device/linaro/dragonboard410c.git/commit/?h=dragonboard&id=dbe30cae1ef227860089e1840aeb1cd140c0003a
hostapd: Add HIDL interface and remove deprecated sepolicies
Add hostapd HIDL interface and remove deprecated hostapd
sepolicies since AOSP no longer have a predefined hostapd
domain and we run into "ERROR 'unknown type hostapd'"
build error instead.
Signed-off-by: Sahaj Sarup [email protected]