feat: better composite action #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
AtomicFS
force-pushed
the
feat/better-composite-action
branch
7 times, most recently
from
f2c1528 to
af922fc
Compare
AtomicFS
added this to the Reduce copy-pasting code when adopting firmware-action milestone
AtomicFS
force-pushed
the
feat/better-composite-action
branch
8 times, most recently
from
4d69816 to
ee145ee
Compare
AtomicFS
force-pushed
the
feat/better-composite-action
branch
from
699da59 to
ca5d93a
Compare
MDr164
reviewed
Mar 10, 2025
AtomicFS
force-pushed
the
feat/better-composite-action
branch
from
ca5d93a to
c2bfe5b
Compare
AtomicFS
force-pushed
the
feat/better-composite-action
branch
2 times, most recently
from
3117260 to
284e24e
Compare
- with this patch the action will automatically cache the produced output files - it also will cache the temporary files, such as time-stamps and so on to detect code changes - the actions/cache actions do not accept dynamically generated arrays, and therefore relecant files are moved in and out - TODO: firmware-action also needs to keep git commit hashes, for the git submodules, to detect reverts and downgrades (these user actions will not be detected with time-stamps) Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- just like we automatically cache, we can now automatically upload artifacts - add inputs specific to artifact uploading which are then just passed over to actions/upload-artifact action Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AI-Generated: true AI-Model: claude-3.5-sonnet Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- just some minor adjustments Signed-off-by: AtomicFS <[email protected]>
- I am adding another task to the Taskfile in the test directory to simulate GitHub CI environment and persuade firmware-action to act like it is in CI Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AI-Generated: true AI-Model: claude-3.5-sonnet Signed-off-by: AtomicFS <[email protected]>
AI-Generated: true AI-Model: claude-3.5-sonnet Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AI-Generated: true AI-Model: claude-3.5-sonnet Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/better-composite-action
branch
from
284e24e to
651db1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am really annoyed by the amount of necessary copy-pasting when using
firmware-actionin GitHub CI. For some complex firmware stacks, when users want various combinations and use multiple matrix strategies, this complexity explodes quite fast. And most of the workflow then is just cache upload, cache download, artifact upload, artifact download.This PR is addressing this. However because GitHub CI has a lot of limitations, and many questionable design decisions, it is not straight forward process. Maybe one way would be to implement GitHub API interface, but I do not want o make that nor maintain that. More rant and details in
action.ymlcomments. Also see #84 for more information (== more rant).Must be merged after #592To function, this PR relies on features introduced in #603
This PR is rather a big deal
It changes significant parts which did not change for a long time. I don't think it will break anything, but we should test this before deploying.
As such, this change should be just drop-in replacement, it should still work even if users do not change anything. The example tests that we are running seem to work fine after some cleanup of redundant code.
Besides these example tests I am also trying it out in firmware-action-example PR. As you can see there, this PR poses a significant simplification and reduction of code needed in the workflow. For example of functional multi-job workflow see run 13686309056
Fixes #84