feat: delete container after use #617
Open
+276
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
AtomicFS
force-pushed
the
feat/delete-container-after-use
branch
from
a5aa3a4 to
23fd4e7
Compare
AtomicFS
force-pushed
the
feat/delete-container-after-use
branch
from
23fd4e7 to
704f8bd
Compare
- in GitHub public runners there is only 14GB of disk space - when building complex firmware stack recursively we often run out of disk space - this new feature removes the Dagger engine after each successful build, freeing up precious space AI-Generated: true AI-Model: claude-3.7-sonnet Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/delete-container-after-use
branch
from
3526c65 to
bbd525b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a container in GitHub CI to conserve disk space.
As mentioned in one of the comments, it is not really possible to delete only the specific container. They are somehow embedded into the Dagger Engine (don't know how, possibly in the attached docker volume). So as a workaround we remove the whole Dagger Engine container and it's volume (but keep Dagger Engine image, to not download it again).
This way keep reclaiming disk space, and surprisingly there is not much time-penalty.
Given how it works under the hood, I thought it would be better to avoid automatic enforcement if GitHub CI is detected, and instead as enable this behavior with optional argument.
fixes #560