Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container cleanup #618

Merged
merged 2 commits into from
Mar 17, 2025
Merged

fix: container cleanup #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f160715
fix(ci): update container cleanup workflow
AtomicFS Mar 14, 2025
ff93c58
docs: add note on discontinued container in docker-compose
AtomicFS Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/container-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
# Remove old containers

name: container cleanup
on: workflow_dispatch
on:
workflow_dispatch:
schedule:
- cron: '0 0 * * 0'
# run weekly

permissions:
contents: read
Expand Down Expand Up @@ -35,6 +39,17 @@ jobs:
fail-fast: false
matrix:
dockerfile: ${{ fromJson(needs.get-matrix.outputs.matrix) }}
# include discontinued containers
include:
- dockerfile: 'coreboot_4.20'
- dockerfile: 'coreboot_4.22'
- dockerfile: 'coreboot_24.02'
- dockerfile: 'edk2-stable202408'
- dockerfile: 'linux_6.1.111'
- dockerfile: 'linux_6.1.45'
- dockerfile: 'linux_6.6.52'
- dockerfile: 'linux_6.9.9'
- dockerfile: 'linux_6.11'
permissions:
contents: read
packages: write
Expand All @@ -54,9 +69,8 @@ jobs:
with:
package-name: firmware-action/${{ matrix.dockerfile }}
package-type: container
min-versions-to-keep: 5
ignore-versions:
'^(main|latest|v(\d+\.?)+)$'
min-versions-to-keep: 3
ignore-versions: '^(main|latest|v(\d+\.?)+)$'
# ignore:
# - main
# - latest
Expand Down
1 change: 1 addition & 0 deletions docs/src/docker/docker-compose.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,4 @@ In addition, there might be `VERIFICATION_TEST_*` variables. These are used insi

- Update entry in list of containers in `README.md`
- Add new regex entry into `Setup()` function in `cmd/firmware-action/container/container.go` to warn about discontinued containers
- Add the discontinued container to `matrix` `include` in `.github/workflows/container-cleanup.yml` to keep even the discontinued containers tidy