-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share prototype #2
base: main
Are you sure you want to change the base?
Conversation
@micaeljtoliveira - If you can have a look at that would be great. This works on my local machine for CICE6 only - see ACCESS-NRI/spack-packages#171 If the approach looks ok, we can make similar changes for MOM6 & WW3 |
I am thinking about changing the export "Namespace" from I also wonder if the library install and bin install specific parts should be split into seperate files which are then included in CMakeLists (e.g. a Access3LibInstall.cmake file and a OM3BinInstall.cmake file) |
I also think I will change OM3_BIN_INSTALL to ACCESS3_BIN_INSTALL because the same Cmake package can be used for Access-cm3/esm3 |
@anton-seaice Before going into the details, here are a few general things to discuss. Looking at how the top CMakeLists.txt file is taking shape, I think it would be better to have a clean separation between the "shared" libraries and the driver, as they have very little in common and the current setup is quite confusing if you are not familiar with it. One option is to have two separate files, as you mentioned above. The other one is to have two different projects. The later might actually be simpler and cleaner, specially because all the sources are included via git submodules. Regarding namespaces, there are two different scopes: CMake variables (e.g., |
Thanks!
Thanks - does this mean seperate repositories ? Or just seperate CMakeLists.txt files in different folders? The two projects would have some duplication I think - e.g. most of the "Project Configuration section" - compiler flags, Fortranlib, MODULEDIR, FindESMF |
Yes, I meant two repositories and yes, there would be some duplication. I would say that's acceptable, because none of the duplicated code is likely to change often, if at all. That being said, you can also have two different project in the same repository. That would be a third option to consider. |
I think we will want to change CMEPS versions & code more often that we need to look at the CMake files, so my preference is to only have CMEPS code in one repository. Along those lines, I created two I poked around the NCAR Cmake a bit, they don't use namespaces for the exports. So ill just change the namespace from |
@anton-seaice Great to have the two |
fd034f8
to
4ccfacb
Compare
The goal of this repository is to provide all the code & build files to build access-om3. The repository has the code to build both common libraries which are used by model components, and to build an executable which contains models components build elsewhere.
There are two things to build:
esmApp
in CMEPS and the model component required - this should support all combinations of including CICE/MOM6/WW3.To-do: