added release_url to component build #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
force-pushed
the
component-release-url
branch
from
7c510e9 to
9f3b1c4
Compare
CodeGat
force-pushed
the
component-release-url
branch
from
9f3b1c4 to
c9905a6
Compare
CodeGat
force-pushed
the
component-release-url
branch
from
c347c2a to
93f7a6c
Compare
CodeGat
force-pushed
the
component-release-url
branch
from
a49d05d to
fcd69fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the combined effort of @utkarshgupta95 adding a
release_urlto the DB schema for model components, and @CodeGat wrangling the model component repository url fromspackand passing it into said script.In this PR:
tools/release_provenance: Update schema to include newrelease_urlfield. Update test data.deploy-2-start.yml: Split Gadi deployment and Gadi metadata-gathering into separate steps. Get model component URLs from thespack pythoncommand and convert to a json filegenerate-build-metadata.bash: Read in above file and add it to the json model+component API that we have going here.Limitations
spack pythoncommand takes around 10s as it is concretizing the spec to get the package details.Resolves #112