Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 'Verify Spack Commits Exist' Check #142

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Disable 'Verify Spack Commits Exist' Check #142

merged 1 commit into from
Oct 4, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Oct 4, 2024 •
edited
Loading

Disabling the Verify Spack Commits Exist Check as the unstable hashes on access-nri/spack make it so the check will almost always fail. See the linked issue for the long term solution.

References #140

@CodeGat
validate-deployment-settings: Comment out check that verifies that sp…
7e17b20 
…ack commits exist due to unstable commit hash
@CodeGat CodeGat self-assigned this Oct 4, 2024
@CodeGat CodeGat requested a review from harshula October 4, 2024 02:05
harshula
harshula approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CodeGat CodeGat merged commit 2e67e4e into main Oct 4, 2024
@CodeGat CodeGat deleted the 140-disable-check-unstable-hashes branch October 4, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

Assignees

@CodeGat CodeGat

Labels
priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeGat @harshula