Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up conda package #2

Closed
wants to merge 3 commits into from
Closed

Set up conda package #2

wants to merge 3 commits into from

Conversation

atteggiani
Copy link
Collaborator

Fixes #1

  • Added conda build and dev environments
  • Added conda recipe for conda package
  • Added pyproject.toml for pip installation in dev mode
  • Added versioneer files for package versioning
  • Added conda build verify to CI
  • Set up CD for conda package upload to accessnri anaconda.org.

I haven't touched the main scripts in this PR, and the new package has the era5grib_parallel entry point, to be called from the rose suite (to be changed in the nci_era5grib_parallel task rose-app.conf file).

@atteggiani atteggiani force-pushed the davide/conda_package branch from d0fb0bf to 5c345dc Compare October 14, 2024 04:08
@atteggiani atteggiani assigned atteggiani and unassigned penguian and engelca Oct 15, 2024
CodeGat
CodeGat requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on the paths that don't have . in .conda in the workflows. Outside of that, just some formatting things.

@atteggiani atteggiani force-pushed the davide/conda_package branch from 5c345dc to 1e5905e Compare October 17, 2024 03:43
@atteggiani atteggiani requested a review from CodeGat October 17, 2024 03:53
CodeGat
CodeGat requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more that snuck through.

@atteggiani atteggiani force-pushed the davide/conda_package branch from 1e5905e to 746d248 Compare October 17, 2024 04:09
@atteggiani atteggiani requested review from CodeGat and removed request for engelca October 17, 2024 04:09
CodeGat
CodeGat previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't think there is a pre-commit check running on this one, but if it needs similar formatting changes it should be a separate PR.

aidanheerdegen
aidanheerdegen requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor changes.

pyproject.toml
keywords = ["ACCESS-RAM", "Regional Nesting Suite", "era5grib"]
dynamic = ["version"]
dependencies = [
"python >=3.10,<=3.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, yeah I think this should be a specific version. We're using 3.10 in payu

https://github.com/ACCESS-NRI/payu-condaenv/blob/main/env.yml#L7

Copy link
Collaborator Author

@atteggiani atteggiani Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is not the right file for that.
This sets the python dependency for the era5grib_parallel conda package (similarly to what is done for the replace_landsurface).

The deployment environment is set in the access-ram-condaenv env.yaml, and we are also using python=3.10 (similar thing is done for the dev deployed environment).
I would personally update this to python=3.11, but I have no strong feelings about it.

An important point is:
Why do we only specify the python's version? Shouldn's we also specify the versions for the other dependencies there?

@atteggiani atteggiani force-pushed the davide/conda_package branch 9 times, most recently from a322863 to 058565d Compare October 26, 2024 00:45
@atteggiani atteggiani force-pushed the davide/conda_package branch from 058565d to 0eb2e0e Compare October 28, 2024 03:56
@atteggiani atteggiani force-pushed the davide/conda_package branch from 0eb2e0e to fb97e50 Compare October 31, 2024 22:41
@atteggiani atteggiani closed this Oct 31, 2024
@atteggiani atteggiani mentioned this pull request Oct 31, 2024
Merged
5 tasks
@atteggiani
Copy link
Collaborator Author

Closed as this PR has been substituted by #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen requested changes

@CodeGat CodeGat CodeGat left review comments

@penguian penguian Awaiting requested review from penguian

Assignees

@atteggiani atteggiani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up conda package
5 participants
@atteggiani @aidanheerdegen @CodeGat @penguian @engelca